fix(objectContaining): Fixed a bug where ObjectContaining matched with non-object values. #15462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h non-object values.
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mohammednumaan
force-pushed
the
fix_object_containing_bug
branch
from
ff0d770 to
569ba43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
objectContainingmethod matches withnon-objectvalues, which is inconsistent. Thanks to @flovouin for finding this bug!This PR fixes: #15420
This PR does the following:
expectis an object.invalidtest cases for the above bug.Test plan
This is the new code I wrote for the
objectContainingimplementation:This is the new test cases I wrote for verifying the above added code works:
To run the tests, I ran the following command:
The test results: